Add support for gRPC and protocol buffers #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for gRPC and protocol buffers to the fetch tool, enabling users to make gRPC requests and work with protobuf messages.
Changes:
- Added gRPC protocol support with framing/unframing and status code handling
- Implemented protobuf schema loading from .proto files or pre-compiled descriptor sets
- Added JSON-to-protobuf conversion for request bodies and protobuf-to-JSON conversion for responses
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| main.go | Added command-line flag bindings for gRPC and protobuf options |
| internal/proto/schema.go | Core schema loading and type resolution for protobuf messages and services |
| internal/proto/schema_test.go | Comprehensive tests for schema loading and type lookup functionality |
| internal/proto/message.go | JSON/protobuf conversion utilities using dynamic message descriptors |
| internal/proto/message_test.go | Tests for bidirectional JSON/protobuf conversion including edge cases |
| internal/proto/descriptor.go | File I/O operations for loading compiled descriptor sets |
| internal/proto/descriptor_test.go | Tests for descriptor set file loading |
| internal/proto/compile.go | Protoc compiler integration for compiling .proto files on-the-fly |
| internal/proto/compile_test.go | Tests for proto compilation with various scenarios |
| internal/grpc/status.go | gRPC status codes and error handling |
| internal/grpc/status_test.go | Tests for gRPC status parsing and formatting |
| internal/grpc/headers.go | Standard gRPC HTTP headers configuration |
| internal/grpc/framing.go | gRPC message framing protocol implementation |
| internal/grpc/framing_test.go | Tests for frame/unframe operations |
| internal/format/protobuf.go | Enhanced protobuf formatting with schema-aware JSON conversion |
| internal/fetch/proto.go | Integration logic for gRPC request/response handling |
| internal/fetch/fetch.go | Main request flow updated to support gRPC protocol |
| internal/complete/complete.go | Added path completion for new proto-related flags |
| internal/cli/app.go | Added CLI flags for gRPC mode and protobuf schema options |
| integration/integration_test.go | Integration tests for protobuf and gRPC features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ryanfowler
force-pushed
the
protobuf
branch
5 times, most recently
from
36d3525 to
037036c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.